fix(name-binding): add extra props to update one time mode #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me. Let's make sure @fkleuver has a look and also considers this for vNext so we don't get a regression there after this is addressed in vCurrent. |
|
This makes good sense to me. This would translate to implementing Just a friendly reminder, you could use this repo for e2e / integration tests: https://github.com/aurelia/e2e-tests |
|
@bigopon do we have a matching issue for this in vNext so I/we don't forget? |
|
Oh, we don't. Will add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to
@edwrd01on Discourse at https://discourse.aurelia.io/t/issue-using-ref-in-a-repeat-for-with-a-value-converter/2328/5 , we uncover an issue related the combination ofrefbinding,repeatandvalue-converter/binding-behavior. The issue is due torepeatcustom attribute unable to update ref binding, in case of a mutation in source collection, piped through value converter / binding behavior. i.e:As it uses this https://github.com/aurelia/templating-resources/blob/0896552d553af0d69399b9b227317a26bdc14005/src/repeat-utilities.js#L109-L115 under the hood to update the bindings that do not employ observation,
NameBinderis one of those binding types. There are two ways to fix it:updateOneTimeBindingsto reassign targetoneTime, and add methodcallto reassign targetI went with (2) since it seems to align better with other bindings, also the location of this class (binding module).
cc @EisenbergEffect @fkleuver